Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semver checks test pr #946

Closed
wants to merge 1 commit into from
Closed

Fix semver checks test pr #946

wants to merge 1 commit into from

Conversation

Lorak-mmk
Copy link
Collaborator

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output 
./scripts/semver-checks.sh --baseline-rev da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
     Cloning da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
     Parsing scylla v0.12.0 (current)
      Parsed [  18.292s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.371s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.062s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-da49a7dedd48a0a2dd7d24e8d1578deeb96735b2/d6c3d8eb772e78bdbd5766c1009f259929e1fe1c/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  35.766s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.674s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.658s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.055s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.423s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk closed this Mar 5, 2024
@Lorak-mmk Lorak-mmk reopened this Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output 
./scripts/semver-checks.sh --baseline-rev da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
     Cloning da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
     Parsing scylla v0.12.0 (current)
      Parsed [  19.227s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  18.118s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.065s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-da49a7dedd48a0a2dd7d24e8d1578deeb96735b2/d6c3d8eb772e78bdbd5766c1009f259929e1fe1c/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  37.453s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.742s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.823s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.058s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.659s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk changed the base branch from main to fix-semver-checks March 5, 2024 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output 
./scripts/semver-checks.sh --baseline-rev da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
     Cloning da49a7dedd48a0a2dd7d24e8d1578deeb96735b2
     Parsing scylla v0.12.0 (current)
      Parsed [  19.225s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.991s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.061s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-da49a7dedd48a0a2dd7d24e8d1578deeb96735b2/d6c3d8eb772e78bdbd5766c1009f259929e1fe1c/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  37.322s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.789s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.815s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.055s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.696s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk force-pushed the fix-semver-checks branch from 0e0a9f6 to 6a4eb48 Compare March 5, 2024 13:18
@Lorak-mmk Lorak-mmk force-pushed the fix-semver-checks-test-pr branch from 96d86f4 to 401694e Compare March 5, 2024 13:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output 
/home/runner/work/_temp/d1aa818f-1a0e-42f7-b446-fdbff1866b5c.sh: line 5: semver-rev: command not found

@Lorak-mmk Lorak-mmk force-pushed the fix-semver-checks branch from 6a4eb48 to 1129f75 Compare March 5, 2024 13:25
@Lorak-mmk Lorak-mmk force-pushed the fix-semver-checks-test-pr branch from 401694e to 24896c8 Compare March 5, 2024 13:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

cargo semver-checks detected some API incompatibilities in this PR.
See the following report for details:

cargo semver-checks output 
./scripts/semver-checks.sh --baseline-rev 1129f75c359962b612dda1711b5657366f96dcd8
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 1129f75c359962b612dda1711b5657366f96dcd8
     Cloning 1129f75c359962b612dda1711b5657366f96dcd8
     Parsing scylla v0.12.0 (current)
      Parsed [  19.076s] (current)
     Parsing scylla v0.12.0 (baseline)
      Parsed [  17.654s] (baseline)
    Checking scylla v0.12.0 -> v0.12.0 (no change)
     Checked [   0.064s] 62 checks; 61 passed, 1 failed, 0 unnecessary

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.29.1/src/lints/struct_missing.ron

Failed in:
  struct scylla::Metrics, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-1129f75c359962b612dda1711b5657366f96dcd8/f53ad5b74819fcbc8f1f30e29c45a7b315337058/scylla/src/transport/metrics.rs:25
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  36.836s] scylla
     Parsing scylla-cql v0.1.0 (current)
      Parsed [   9.683s] (current)
     Parsing scylla-cql v0.1.0 (baseline)
      Parsed [   9.535s] (baseline)
    Checking scylla-cql v0.1.0 -> v0.1.0 (no change)
     Checked [   0.054s] 62 checks; 62 passed, 0 unnecessary
    Finished [  19.307s] scylla-cql
make: *** [Makefile:53: semver-rev] Error 1

@Lorak-mmk Lorak-mmk closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lorak-mmk